feat(connectors): allow skipping OAuth with Esc key #217

Paveltarno · 2026-02-09T14:25:33Z

Note

Description

This PR enhances the OAuth authorization flow for connectors by allowing users to skip individual connector authorization with the Esc key (or Ctrl+C), rather than terminating the entire CLI process. This improves UX when pushing multiple connectors by letting users skip problematic ones and continue with the rest. The implementation works around a clack bug where block() calls process.exit(0) on cancel keys.

Related Issue

None

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (no functional changes)
Other (please describe):

Changes Made

Added new SKIPPED status to OAuthFlowStatus type
Renamed runOAuthFlow to runOAuthFlowWithSkip to reflect new skip capability
Implemented temporary process.exit override to intercept Esc/Ctrl+C and set skipped flag instead of killing the process
Added spinner with "Esc to skip" instruction during OAuth authorization polling
Updated summary display to show skipped connectors in yellow
Updated tests to use new function name and mock the @clack/prompts spinner

Testing

I have tested these changes locally
I have added/updated tests as needed
All tests pass (npm test)

Checklist

My code follows the project's style guidelines
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (if applicable)
My changes generate no new warnings
I have updated AGENTS.md if I made architectural changes

Additional Notes

The implementation uses a temporary override of process.exit to intercept the cancel signal from clack's block() function, which normally calls process.exit(0) directly instead of emitting SIGINT. This workaround ensures the spinner's cancellation is properly handled and the CLI can continue to the next connector instead of exiting entirely.

_{🤖 Generated by Claude | 2026-02-10 15:22 UTC}

github-actions · 2026-02-09T14:26:04Z

🚀 Package Preview Available!

Install this PR's preview build with npm:

npm i @base44-preview/cli@0.0.30-pr.217.2ff8369

Prefer not to change any import paths? Install using npm alias so your code still imports base44:

npm i "base44@npm:@base44-preview/cli@0.0.30-pr.217.2ff8369"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "base44": "npm:@base44-preview/cli@0.0.30-pr.217.2ff8369"
  }
}

📦 Preview Package: @base44-preview/cli@0.0.30-pr.217.2ff8369
🔗 View this commit on GitHub

_{Preview published to npm registry — try new features instantly!}

Add connector resource module supporting 12 OAuth providers: googlecalendar, googledrive, gmail, googlesheets, googledocs, googleslides, slack, notion, salesforce, hubspot, linkedin, tiktok. - Zod discriminated union schema with type discriminator per provider - JSDoc links to official OAuth scope documentation for each provider - JSONC file reading with validation (filename must match type field) - API response schemas for upstream connector state - Unit tests with fixtures for valid, invalid, and mismatched connectors Part of: #184 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add API client methods for OAuth connector operations: - listConnectors: list all connectors for current app - syncConnector: sync connector with exact scope matching - getOAuthStatus: poll OAuth authorization status - removeConnector: remove a connector integration Also update response schemas and clean up verbose comments. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

* feat(connectors): implement push logic for syncing connectors Add pushConnectors function that: - Syncs all local connectors via /sync endpoint - Removes upstream-only connectors not in local config - Returns typed results (synced, removed, needs_oauth, error) Includes unit tests covering all scenarios. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(connectors): add OAuth flow handling with browser redirect and polling (#192) * feat(connectors): add OAuth flow handling with browser redirect and polling Add runOAuthFlow function that: - Opens OAuth redirect URL in browser - Polls getOAuthStatus until ACTIVE or FAILED - Returns PENDING on timeout (5 minutes) Uses p-wait-for TimeoutError for robust timeout detection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * connectors: base44 connectors push (#194) * final connector work sofi 1 * scopes --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Change provider field from closed enum to flexible union that accepts both known providers (googlecalendar, notion, slack, etc.) and any arbitrary provider string. This enables users to configure custom OAuth providers without waiting for first-class Base44 support. Schema changes: - Add GenericConnectorSchema for arbitrary provider types - Update ConnectorResourceSchema to union of specific + generic schemas - Update IntegrationTypeSchema to accept known enum OR any non-empty string - Only reject empty strings Test coverage: - Verify known providers continue to work - Verify arbitrary providers are accepted - Verify empty strings are rejected - All 137 tests passing Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Override process.exit temporarily during the spinner to intercept Ctrl+C/Escape (which clack's block() converts to process.exit(0)), letting users skip individual connector authorizations instead of killing the entire process. Adds SKIPPED status to the summary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

claude · 2026-02-10T15:31:44Z

Code review

Found 1 issue that needs attention:

Issue: User instruction does not match actual behavior

Location: src/core/resources/connector/oauth.ts:44

The spinner message tells users to press Esc to skip:

s.start(`Waiting for ${params.type} authorization... (Esc to skip)`);

However, the actual skip mechanism works by intercepting process.exit, which is only called by Clack's block() function when the user presses Ctrl+C, not Esc. This is correctly documented in the code comment (lines 23-26).

Problem: When users press Esc (as instructed), nothing happens. They will be stuck waiting for the 2-minute timeout. Only Ctrl+C will trigger the skip.

Suggested fix: Change the message to match the actual mechanism:

s.start(`Waiting for ${params.type} authorization... (Ctrl+C to skip)`);

References:

Line 44:

cli/src/core/resources/connector/oauth.ts

Lines 43 to 45 in 99b7274


	s.start(`Waiting for ${params.type} authorization... (Esc to skip)`);

Comment:

cli/src/core/resources/connector/oauth.ts

Lines 22 to 27 in 99b7274

    
           /** 
        
            * Clack's block() puts stdin in raw mode where Ctrl+C calls process.exit(0) 
        
            * directly instead of emitting SIGINT. We override process.exit temporarily 
        
            * so Ctrl+C skips the current connector instead of killing the process. 
        
            */

kfirstri

I commented this in the parent PR #189

the entire pWaitFor should not be in the core/ folder.. and in this PR there's now also spinners and more stuff which core/ packages should not be familiar with.

kfirstri added this to CLI Development Feb 9, 2026

github-project-automation bot moved this to Backlog in CLI Development Feb 9, 2026

dor-chaouat moved this from Backlog to In progress in CLI Development Feb 9, 2026

Paveltarno and others added 7 commits February 10, 2026 13:59

chore: add .worktrees to .gitignore

329ffd9

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

fix(connectors): make scopes optional for Notion provider (#213)

f1cbb7e

review fixes

7b418ac

Paveltarno force-pushed the pavelta-connectors-1 branch from 7bfb43f to 7b418ac Compare February 10, 2026 11:59

Paveltarno and others added 6 commits February 10, 2026 14:05

lint

1dde7a5

remove push messages

6cc514e

notion is optional

e81ce6d

minor changes

c6d4dea

tsc + lint

9f0d47f

Paveltarno force-pushed the pavelta-connectors-skip-oauth branch from e304a12 to 3d50451 Compare February 10, 2026 15:18

fixes

99b7274

base44 deleted a comment from claude bot Feb 10, 2026

kfirstri requested changes Feb 11, 2026

View reviewed changes

github-project-automation bot moved this from In progress to Ready in CLI Development Feb 11, 2026

Paveltarno force-pushed the pavelta-connectors-1 branch from 0d6430f to 3fc2e0c Compare February 11, 2026 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connectors): allow skipping OAuth with Esc key #217

feat(connectors): allow skipping OAuth with Esc key #217

Uh oh!

Paveltarno commented Feb 9, 2026 •

edited by claude bot

Loading

Uh oh!

github-actions bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

claude bot commented Feb 10, 2026

Uh oh!

kfirstri left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(connectors): allow skipping OAuth with Esc key #217

Are you sure you want to change the base?

feat(connectors): allow skipping OAuth with Esc key #217

Uh oh!

Conversation

Paveltarno commented Feb 9, 2026 • edited by claude bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Changes Made

Testing

Checklist

Additional Notes

Uh oh!

github-actions bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Package Preview Available!

Uh oh!

claude bot commented Feb 10, 2026

Code review

Issue: User instruction does not match actual behavior

Uh oh!

kfirstri left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Paveltarno commented Feb 9, 2026 •

edited by claude bot

Loading

github-actions bot commented Feb 9, 2026 •

edited

Loading